-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect fresh state and auto-apply Snapcast defaults #776
Comments
Renaming to Feature request as the current functionality is not broken, rather it is a request to expand the feature. Personally I would like to change how this works, and instead have a server-side full set of defaults (ie not just for Snapcast). |
Thinking further about this, I think the best approach is to piggyback the existing "Share configuration" flow. Instead of sending the selected config to another user, an option would exist where you could select "System defaults". This feels like a practical option allowing the user to determine what is saved as the available defaults (including sensitive tokens, like Spotify Auth). |
Resolved indirectly by expanding Share configuration to push configuration to the server, so any other users can import it. Also worth noting is that you can pre-seed your configuration via URL parameters. |
Thanks, but that's still very cumbersome as the configuration pushed/saved to the server is not auto-loaded when a new user openes the iris interface or e.g. after deleting browser cache. So the user still has to go manually to setting and import the configuration from the server, this is just something a "regular consumer" isn't capable of, they need to be able to click the url and find everything working ootb. I'm with mczerski here #848 (comment) a good old setting in Edit: Thanks for the pre-seed configuration via URL parameters, I'll go for that workaround for now. |
Describe the bug
First huge thanks for adding these options, since here it often happens users cleared their browser data, especially on mobile devices, and then found themselves not being able to use iris as snapcast was unconfigured again.
Now having configured the snapcast options (https://github.com/jaedb/Iris/wiki/Getting-started#configuration) and cleared browser history and/or opening iris in a privat browser tab, the initial configuration doesn't seem to get loaded from mopidy.conf.
To Reproduce
Steps to reproduce the behavior:
/etc/mopidy/mopidy.conf
stop/start or restart mopidy.service
clear browser history and/or use privat tab to ensure nothing is cashed
be presented with the initial "Welcome to Iris" screen and hit "Save"
find clicking on the volume bar report "no outputs" and "Could not get Snapcast server" error message displayed
review configuration screen and see values are not picked up from mopidy.conf
click "Restore defaults" once
See the correct values appearing and things starting to work correctly
Expected behavior
When viewing iris for the first time have it read out the configured default values and respect them without having to click "Restore defaults" first when the user didn't do any manual changes which would justify not loading/restoring the defaults configured in mopidy.conf.
Environment details:
The text was updated successfully, but these errors were encountered: