Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL not properly set on <Stream> component #775

Closed
kiwiz opened this issue Oct 9, 2021 · 1 comment
Closed

SSL not properly set on <Stream> component #775

kiwiz opened this issue Oct 9, 2021 · 1 comment
Labels

Comments

@kiwiz
Copy link

kiwiz commented Oct 9, 2021

Describe the bug
When trying to connect to a Snapcast server over HTTPS, the control connection appears to be correctly established over https (or wss?), but the stream connection is always set to use ws.

From a quick look in Dev Console, it sees that the ssl prop for the <Stream> component is never populated and is undefined.

If I understand properly, this could be resolved by adding a ssl field to the snapcast state in js/store/index.js?

To Reproduce
Steps to reproduce the behavior:

  1. Serve up Iris and the Snapcast server via an HTTPS server.
  2. Configure Snapcast and click "Streaming enabled"

Expected behavior
The stream should start playing in the browser.

I've confirmed that setting ssl to true via the debugger properly connects to the stream.

Console log
(relevant bit)

Uncaught DOMException: The operation is insecure. SnapStream.tsx:853:6
    connect SnapStream.tsx:853
    SnapStream SnapStream.tsx:821
    Stream Stream.js:27
    Stream Stream.js:12

Environment details:

  • OS: Linux
  • Browser: Firefox
  • Iris version: 3.59.1
@kiwiz kiwiz added the bug label Oct 9, 2021
@choseh
Copy link

choseh commented Oct 19, 2021

same here.

Mixed Content: The page at 'https://iris.foo.bar/iris/queue' was loaded over HTTPS, but attempted to connect to the insecure WebSocket endpoint 'ws://iris.foo.bar:443/stream'. This request has been blocked; this endpoint must be available over WSS.

@jaedb jaedb closed this as completed in 6110ef8 Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants