Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max width on images within TinyMCE #17

Closed
jacobobryant opened this issue Jun 18, 2022 · 4 comments
Closed

Set max width on images within TinyMCE #17

jacobobryant opened this issue Jun 18, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@jacobobryant
Copy link
Owner

The grumpycat picture in #14 reminded me that images in the editor are displayed at full width. Better if we make them shrink so they don't overflow on the x axis.

@jacobobryant jacobobryant added the good first issue Good for newcomers label Jun 18, 2022
@jeffp42ker
Copy link
Contributor

jeffp42ker commented Jun 18, 2022

I've been manually re-sizing images to 800 or 1024 pixel-width prior to upload. I'd be nice to skip that if upload-image could handle that step.

@jacobobryant
Copy link
Owner Author

Hm, that should be doable... I've made a second issue for this: #23

@jacobobryant
Copy link
Owner Author

(for this issue I'm basically just thinking about setting style="max-width:..." on image elements inside TinyMCE; I'm hoping TinyMCE has an option for that we can flip on)

@jacobobryant
Copy link
Owner Author

I went ahead and fixed this because I was writing a post with a bunch of images and it was super annoying, also a quick google search turned up the solution (a one-liner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants