Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve homebrew formula and automate publishing process #72

Closed
jacobdeichert opened this issue Aug 11, 2020 · 3 comments
Closed

Improve homebrew formula and automate publishing process #72

jacobdeichert opened this issue Aug 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jacobdeichert
Copy link
Owner

jacobdeichert commented Aug 11, 2020

I just noticed that the homebrew formula depends on rust to compile.

A better and faster way is to just download the precompiled mask-vX.X.X-x86_64-apple-darwin.zip which is built and attached to every release. This way the homebrew user doesn't need to have the rust toolchain installed.

@jacobdeichert jacobdeichert added the enhancement New feature or request label Aug 11, 2020
@jacobdeichert
Copy link
Owner Author

There's a related PR for automating the homebrew formula process, so we should do this before that merges.

@jacobdeichert jacobdeichert changed the title Improve homebrew formula update process Improve homebrew formula and automate publishing process Aug 11, 2020
@vladimyr
Copy link
Contributor

I just noticed that the homebrew formula depends on rust to compile.

Only if you decided to build it locally. ☝️ There are prebuilt binaries named bottles: https://formulae.brew.sh/api/formula/mask.json

A better and faster way is to just download the precompiled mask-vX.X.X-x86_64-apple-darwin.zip which is built and attached to every release. This way the homebrew user doesn't need to have the rust toolchain installed.

Due to the formula being bottled there is no need to alter it (users don't need to download rust and compile it locally). Also, Homebrew doesn't let people distribute binaries they built around → https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

@jacobdeichert
Copy link
Owner Author

@vladimyr thanks for clarifying! Didn't know about bottling 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants