-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pybigtools: NumPy 2.0 #43
Comments
Re: ABI compatibility https://numpy.org/doc/stable/dev/depending_on_numpy.html#numpy-2-0-specific-advice
So for [build-system]
requires = ["maturin>=1.0,<2.0", "numpy>=2.0,<3.0"]
build-backend = "maturin"
... |
That seems fine - I did a bit of testing and didn't encounter any problems. |
I take it back. For pyO3-based bindings, the build time dependency that matters is rust-numpy. |
It's still not clear to me whether or not there could be ABI incompatibility between pybigtools and a Python environment that uses numpy 2.0. However, pybigtools currently depends on We should probably bump |
I've upgraded to rust-numpy 0.22 on master. |
The pybigtools v0.2.4 release contains rust-numpy 0.22, so closing this. |
Numpy just released its 2.0, which includes ABI breaks, and a migration guide. We should check that nothing breaks or pin
numpy < 2
until migration is complete.The text was updated successfully, but these errors were encountered: