-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove prepare operation in copy from #1085
base: master
Are you sure you want to change the base?
feat: remove prepare operation in copy from #1085
Conversation
I think that step is necessary to handle native Go values like |
I have same question, I'm using extension(pipelinedb), there is no simple select from table that pgx tries to prepare statement. Removing prepare statements would help for me too. |
@mixmind You could drop down to the pgconn level and construct the copy stream manually. See https://pkg.go.dev/github.com/jackc/pgconn#PgConn.CopyFrom. |
@KennyChenFight any thought on Jack’s comment? |
Hi @jackc we are using CopyFrom in a write intensive application. I wanted to get rid of the prepare statement, would you accept a PR that exposes a new |
@alejandrodnm I don't mind an improvement to copy from performance, but I'm not convinced that a What about |
Sounds good @jackc , I'll give it a try. Thanks |
I think it's not necessary to use prepare operation to set value type before copy from operation. It would produce one RTT and slow down copy from operation.