HttpClient: refactor the way we clean utm_ query params #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jan 23, 2021
Also: - test PHP 8.1 - update to PHPStan@1 - allow symfony/* 6.0
Type everything
Kdecherf
force-pushed
the
fix/utm-query
branch
2 times, most recently
from
6dfe4d5 to
1fb0ea3
Compare
The old preg_replace call incorrectly removed the ? of the query string section which could lead to things like this: http://example.com/foo?utm_source=a&var=value => http://example.com/foo&var=value Signed-off-by: Kevin Decherf <[email protected]>
As per RFC3986, Section 3.4 indicates that we can avoid percent-encoding the'/' and '?' characters. However the '=' character in the nested query string should be encoded. Signed-off-by: Kevin Decherf <[email protected]>
Uri::withQueryValues() has been added in psr7 1.5.0 but our direct dependency http-factory-guzzle is currently set to require ^1.4.2 which could cause issues on some installations. Signed-off-by: Kevin Decherf <[email protected]>
Kdecherf
force-pushed
the
fix/utm-query
branch
from
1fb0ea3 to
8bcef77
Compare
|
Sh*t I fucked up the PR when changing the base branch and then merged it 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
preg_replacecall incorrectly removed the?of the query stringsection which could lead to things like this:
http://example.com/foo?utm_source=a&var=value=>http://example.com/foo&var=value