Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brand new logo to the project #214

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Add brand new logo to the project #214

merged 3 commits into from
Oct 21, 2019

Conversation

caneco
Copy link
Contributor

@caneco caneco commented Oct 4, 2019

Following your request in the tweet:
https://twitter.com/j0k/status/1180008533619888128

Here it is your brand new logo. Hope you like it!

image

@caneco
Copy link
Contributor Author

caneco commented Oct 4, 2019

I like the idea that the "G" can "grab" something… but I'm not a truly fan of the thing, so here's another option.

image

Maybe you can play of the holding G for other stuff?

@coveralls
Copy link

coveralls commented Oct 4, 2019

Coverage Status

Coverage increased (+0.005%) to 96.52% when pulling 1ebdb1e on caneco:master into 0657ab3 on j0k3r:master.

@jtojnar
Copy link
Collaborator

jtojnar commented Oct 4, 2019

Wow, I love the hand idea, and the colours too. To make it grab something like an article would be nice touch but I cannot imagine doing it in a way that would not completely destroy the logo 😞

PS: It should be Graby with single b.

@caneco
Copy link
Contributor Author

caneco commented Oct 5, 2019

@jtojnar sorry the misspell… I had the same idea for the G to be holding an article, but it maybe confuse the thing. Going to try it anyway 😃

@j0k3r
Copy link
Owner

j0k3r commented Oct 5, 2019

Nice job!
I agree with @jtojnar about the G grabbing an article. Let’s see what you can try ☺️

@caneco
Copy link
Contributor Author

caneco commented Oct 5, 2019

Hello again… before I update the PR, what do you think about this approach?

image

@j0k3r
Copy link
Owner

j0k3r commented Oct 6, 2019

I prefer that one.
Can we merge the G with the rest of the word, so it’s not Ggraby? ☺️

@jtojnar
Copy link
Collaborator

jtojnar commented Oct 6, 2019

Could you also check how does it look like on a dark backgroung? I use https://github.com/StylishThemes/GitHub-Dark and the white background of the current image is little jarring:

image

@j0k3r
Copy link
Owner

j0k3r commented Oct 17, 2019

@caneco any news? :)

@caneco
Copy link
Contributor Author

caneco commented Oct 17, 2019

Hello, sorry I totally miss left this aside :shame:

So, regarding your comments here are mine:

Can we merge the G with the rest of the word, so it’s not Ggraby?
It's better not… either way could mislead people to read "RABY" 😕
Sorry, but need to blame the "holding article" 😅… that's on me
image

Could you also check how does it look like on a dark backgroung?
On black, actually it would be better to have your suggestion above but without the "holding article"
image
but all in white…

image

Comments?

@jtojnar
Copy link
Collaborator

jtojnar commented Oct 17, 2019

I am rather fond of purple. Could we keep that even on dark background?

Other than that SVG variant should be committed to the repo and a license should be decided. Do we want to use Graby’s MIT, or use something like CC or Art Libre like Wallabag does for its logo.

@caneco
Copy link
Contributor Author

caneco commented Oct 17, 2019

@jtojnar meaning the one without holding the article?

@caneco
Copy link
Contributor Author

caneco commented Oct 21, 2019

@jtojnar meaning the one without holding the article?
do you?

@jtojnar && @j0k3r regarding the SVG version I'm postponing that subject to November, according to the CoC released

@j0k3r
Copy link
Owner

j0k3r commented Oct 21, 2019

No problem for the SVG version later.
I like the second one, with the G size more aligned with raby. I think the final version can be this one with the text/card inside the G.

As a bonus, can we see how the colorful logo render with a black background?

@caneco
Copy link
Contributor Author

caneco commented Oct 21, 2019

Like this?

image
(on white)

image
(on black)

@j0k3r
Copy link
Owner

j0k3r commented Oct 21, 2019

Yup like this 👍
The SVG (or the PNG) will have to have a transparent background and it'll be ok on both white & black background.

You can update the PR

@caneco
Copy link
Contributor Author

caneco commented Oct 21, 2019

Just updated the PR! Go for it!!! 🎉

@jtojnar
Copy link
Collaborator

jtojnar commented Oct 21, 2019

Looks superbly.

However, would you mind moving the credits to the bottom of the README like selfoss or Wallabag do? It is important to provide attribution but, in my opinion, the README is meant to quickly help the user find out, in this order:

  1. What the repo is about?
  2. How to make it run?
  3. How to use it?
  4. How to contribute?

The order is designed to copy the stages user will enter when interacting with the software. That means, that it is not appropriate to put the credits at the top, since it would delay user from achieving their goal.

And since we do not have the option of overlaying the credits over the content like TV series have, we can only create a separate section at the end:

  1. Who is behind it?

Disclaimer: I am only occasional contributor, not a project member, so take this just as a suggestion.

@j0k3r
Copy link
Owner

j0k3r commented Oct 21, 2019

@jtojnar don't worry, I'll update the README later :)

Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @caneco for this awesome logo 🥇

@j0k3r j0k3r merged commit 590b71d into j0k3r:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants