check for min tls version #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
force-pushed
the
tls
branch
4 times, most recently
from
936efb6 to
8619269
Compare
izar
reviewed
Dec 29, 2020
pytm/pytm.py
Outdated
| TLSVersion.NONE, | ||
| required=False, | ||
| doc="""Minimum required TLS version required. | ||
| Note that currently only TLS 1.2 and 1.3 are considered secure.""", |
There was a problem hiding this comment.
just wondering if the comment about the versions is not better suited for the actual threat. First, the versions will probably move and we will have to chase them here, second, on a more meta level, this adds a level of judgement that i don't think is present in other attributes (off memory, I didn't check)
There was a problem hiding this comment.
Yep, I think this needs changing.
There was a problem hiding this comment.
I removed the note and I noticed that required is used twice.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for min tls version, similar to how we check for max classification.
Remove
usesLatestTLSversionsince it's not precise enough what's "latest".