Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed tf.concat for paddle, tensorflow backends #28416

Closed
wants to merge 1 commit into from

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

Fixed tf.concat for paddle, tensorflow backends

image

Related Issue

Closes #28413
Closes #28414

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Feb 25, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sai-Suraj-27
Thanks for you continuous efforts.
Could you briefly explain how these two imports supposedly fix tf.concat. I just ran test_tensorlow_concat and it seems to pass anyway.

@Sai-Suraj-27
Copy link
Contributor Author

Sai-Suraj-27 commented Mar 6, 2024

Hi @Sai-Suraj-27 Thanks for you continuous efforts. Could you briefly explain how these two imports supposedly fix tf.concat. I just ran test_tensorlow_concat and it seems to pass anyway.

Hey, @Ishticode. I made this PR almost 2 weeks back. So, I don't exactly remember what the error was, but it was happening due to some import problems, and I figured out that adding these 2 missing __init__.py files fixes the failing tests of test_tensorlow_concat.

Regarding the tests passing successfully now, the reason for this, is that @vedpatwardhan made this PR (#28452) which adds these 2 __init__.py files and merged it to main, to release a new version i guess. So, it fixed this failing of test_tensorlow_concat also.

@Ishticode
Copy link
Contributor

In that case we can perhaps close this. Thanks :) @Sai-Suraj-27

@Ishticode Ishticode closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
3 participants