Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added scatter_nd tensorflow frontend function #27274

Closed
wants to merge 3 commits into from

Conversation

Dofften
Copy link
Contributor

@Dofften Dofften commented Nov 14, 2023

Related Issue

Closes #27242

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "Feat", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Nov 14, 2023
@Dofften
Copy link
Contributor Author

Dofften commented Nov 14, 2023

Hello @MahmoudAshraf97 ,
I've created this new Pull Request for further modifications. There are some errors that I am running into during testing. Kindly guide me on how to further improve my code to get this PR merged.

Thanks you for your assistance.

@Dofften Dofften changed the title Added scatter_nd tensorflow frontend function Feat: Added scatter_nd tensorflow frontend function Nov 16, 2023
@soma2000-lang
Copy link
Contributor

@Dofften can you please look into the failing tests.

@Ishticode
Copy link
Contributor

Closing this due to inactivity for over 5 months after test failure fix was requested. Please feel free to reopen if would like to continue working on this. Thanks :)

@Ishticode Ishticode closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scatter_nd
7 participants