Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth: What format is allowed_domains in? #24

Open
aragilar opened this issue Nov 17, 2024 · 1 comment
Open

oauth: What format is allowed_domains in? #24

aragilar opened this issue Nov 17, 2024 · 1 comment

Comments

@aragilar
Copy link

It could be bare domains, include ports or subpaths, or something else?

See #22 for context.

@mbtaylor
Copy link
Member

One possibility would be an origin (or list of origins), as defined by RFC6454. Origin is a triple of scheme, hostname and port, and has the benefit that it's been thought through from a security perspective. But it's no good as it stands if we want to restrict on subpath as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants