Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error types and relation to Measurement model Uncertainty #60

Open
mcdittmar opened this issue Oct 28, 2024 · 4 comments
Open

Error types and relation to Measurement model Uncertainty #60

mcdittmar opened this issue Oct 28, 2024 · 4 comments

Comments

@mcdittmar
Copy link
Collaborator

These comments are on version (commit 27c4bd3) and follow #59.

In this model:

  • PropertyError: extends Meas:Uncertainty with "confidenceLevel"
    • In Ian's talk in Sydney, one of his conclusions was "Even quoting measurement and confidence limits don’t forget that the shape of the distribution (e.g., Gaussian) and the confidence level (e.g., 68%, 95%) must be captured for the measurement to be useful"
    • So this confidenceLevel should be proposed as an update to the Meas:Uncertainty type.

This would create a bit of a cascade, since Mango currently has all of the relevant error types for this use case extending PropertyError so that they have the confidenceLevel attribute.. however

  • mango:error.Symmetric1D is equivalent to meas:Symmetrical
  • mango:error.Asymmetric1D is equivalent to meas:Bounds1D
  • mango:error.Ellipse is equivalent to meas:Ellipse
    There are variations in the attribute names and structure, but the definitions are the same. We should avoid such duplication of objects.

If confidenceLevel were moved into meas:Uncertainty, the only Error items needed in Mango would be the ErrorCorrMatrix and ErrorCovMatrix objects.. unless these are decided to be properly generic for migration to Measurements, but I think that is another topic.

@lmichel
Copy link
Collaborator

lmichel commented Nov 5, 2024

PropertyError: extends Meas:Uncertainty with "confidenceLevel"

We should add a distribution attribute (poisson, gaussian,... ) along with the confidence level.

@lmichel
Copy link
Collaborator

lmichel commented Nov 5, 2024

confidenceLevel should be proposed as an update to the Meas:Uncertainty type

This has been proposed by François Xavier Pineau (@fxpineau) in the RFC1 (post from 2019-09-24).
This proposal has been discarded because it didn't cover any model use-case (see thread). On the other hand, it's part of the MANGO's use-cases.
It's certainly a shame, but I don't think there's anything to be gained by starting a process to update Meas before MANGO is adopted. It would take an enormous amount of time for a hypothetical gain.

@lmichel
Copy link
Collaborator

lmichel commented Nov 5, 2024

mango:error.Symmetric1D is equivalent to meas:Symmetrical

Yes, this is a way to implement the model view we were talking about at last running meeting.
These Mango classes import concepts from Meas and apply them in its own context.

@lmichel
Copy link
Collaborator

lmichel commented Nov 5, 2024

mango:error.Ellipse is equivalent to meas:Ellipse

mango:ellipse is not exactly equivalent to meas:ellipse in a sense that the latter attaches roles (major axis vs minor axis) to vector coordinates (Ellipse.semiAxis card=2), whereas MANGO use explicit attributes for each of the axes.
After playing with MIVOT, it turned out that the attribute approach is easier to use.

However, MANGO imports Meas's definitions and uses them in its own context, so that both models keep compliant .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants