Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dicom writer error: Offset is outside the bounds #335

Closed
rafasoyyo opened this issue Apr 28, 2017 · 7 comments
Closed

Dicom writer error: Offset is outside the bounds #335

rafasoyyo opened this issue Apr 28, 2017 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@rafasoyyo
Copy link
Contributor

From #264
I cannot use Dicom Writer
It always throws the error: Offset is outside the bounds of the DataView.
Maybe I am doing something wrong...
I have attached a file with my code
writer.zip

@ivmartel ivmartel added the bug Something isn't working label Apr 28, 2017
@ivmartel ivmartel added this to the 0.20.0 milestone Apr 28, 2017
@ivmartel
Copy link
Owner

ivmartel commented May 9, 2017

The dicomWriter.test are passing and I can anonymise the dwv-test-anonymise.dcm data using the anonymiser html page.

Now the DICOM support for the writer is limited, maybe the data you are using was not tested, could you share some?

About your code, the file writer takes a blob as input not the raw buffer. Check out the anonimyser code.

@ivmartel
Copy link
Owner

Hi @rafasoyyo, did you make any progress on this one?

@yuliacech
Copy link
Contributor

Hi @ivmartel,
I actually have a question about writer support. Currently it only allows syntax 1.2.840.10008.1.2.1 (Explicit VR - Little Endian).
What I did was, I took a file with 1.2.840.10008.1.2.4.91 (JPEG 2000 Image Compression), parsed it with DicomParser, then created a file with DicomWriter and parsed it again. Then I compared both dicomElementsSets with http://unexpected.js.org/ (because it handles large arrays of pixel data better).
Since both dicomElementsSets are identical, specifically, both pixel data arrays are equal, I assumed that this syntax can be supported as well.

What do you think? I could create a merge request for this test, if you like.

Best,

Yulia

@ivmartel ivmartel changed the title Dicom Writer Dicom writer error May 17, 2017
@ivmartel ivmartel changed the title Dicom writer error Dicom writer error: Offset is outside the bounds May 17, 2017
@ivmartel
Copy link
Owner

@yulia-tue, it seems reasonable, I create #343 to record the change.

@rafasoyyo
Copy link
Contributor Author

Sorry @ivmartel, I had no time. I will have a look this weekend and I will notify you what append.

@rafasoyyo
Copy link
Contributor Author

Hi @ivmartel, you were right, DicomWriter works fine but my dicom is not supported.
I have solved my needs on server side using dcmtk, but anyway I think it would be a nice feature, so let my know If I can help you or @yulia-tue just to improve DicomWriter support.

@ivmartel
Copy link
Owner

Ok, so I close this issue. The work needed to improve the writer has been described in #343.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants