Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI PhantomJs to 2.1 #287

Closed
ivmartel opened this issue Nov 16, 2016 · 2 comments
Closed

Update CI PhantomJs to 2.1 #287

ivmartel opened this issue Nov 16, 2016 · 2 comments
Labels
enhancement New feature or request
Milestone
0.18.0

Comments

@ivmartel
Copy link
Owner

The Continuous Integration (CI) platform, namely Travis, runs a Grunt task called grunt-qunit-istanbul. This tasks uses a headless webkit called PhantomJs.

The current version of PhantomJs is of the 1.9 series of 2013 when the current series are v2.1 (see releases). This old version does not provide all the functionality needed for dwv and makes testing difficult (see comments in the dicomParser.test.js#L9 file).

This must be updated as soon as possible!
@ivmartel ivmartel added the enhancement New feature or request label Nov 16, 2016
@ivmartel ivmartel added this to the Future milestone Nov 16, 2016
@ivmartel
Copy link
Owner Author

Latest try using grunt-qunit-istanbul v1.0 failed, see builds/176212863.

The problem seem to come from the instrumentedFiles option: when left empty the tests pass but the tasks ends with a 'rimraf' exception...

@ivmartel ivmartel modified the milestones: 0.18.0, Future Jan 18, 2017
@ivmartel ivmartel mentioned this issue Jan 18, 2017
Merged
@ivmartel
Copy link
Owner Author

Closed with #305!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
1 participant
@ivmartel