Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image data range and rescaled range are not correct #1404

Closed
ivmartel opened this issue Jun 14, 2023 · 2 comments
Closed

Image data range and rescaled range are not correct #1404

ivmartel opened this issue Jun 14, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
0.33.0

Comments

@ivmartel
Copy link
Owner

The values returned by image.getDataRange() and image.getRescaledDataRange() are just for the first loaded slice and not for the whole volume. The values returned by the calculate equivalents are correct.
@ivmartel ivmartel added the bug Something isn't working label Jun 14, 2023
@ivmartel ivmartel added this to the 0.33.0 milestone Jun 14, 2023
@ivmartel
Copy link
Owner Author

In the default case, when the data is rendered at first load, the view class creates a minmax window level preset that triggers the image range calculation and storage. These values are not updated afterwards. The range could be updated in the appendSlice method so that, once all loaded, the getRange methods return the correct values.

@ivmartel
Copy link
Owner Author

ivmartel commented Jun 14, 2023 •
edited
Loading

Fixed in e1cf4c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.33.0
Development

No branches or pull requests
1 participant
@ivmartel