Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DICOM to store annotations #1020

Closed
ivmartel opened this issue Oct 21, 2021 · 5 comments · Fixed by #1767
Closed

Use DICOM to store annotations #1020

ivmartel opened this issue Oct 21, 2021 · 5 comments · Fixed by #1767
Labels
enhancement New feature or request
Milestone

Comments

@ivmartel
Copy link
Owner

ivmartel commented Oct 21, 2021

The current code saves presentation and drawing information in a json state file. This storage is not standard and cannot be shared easily. DICOM storage must be studied to replace the json file. For example:

@ivmartel ivmartel added the enhancement New feature or request label Oct 21, 2021
@ivmartel ivmartel added this to the Future milestone Oct 21, 2021
@ivmartel ivmartel modified the milestones: Future, 0.31.0 Dec 30, 2021
@wangwendong-code
Copy link

are you working with this?

@ivmartel
Copy link
Owner Author

ivmartel commented Mar 4, 2022

Not right now, not sure when I will be able to... Any help is appreciated!

@ivmartel ivmartel modified the milestones: 0.31.0, 0.33.0 Mar 17, 2022
@ivmartel ivmartel modified the milestones: 0.33.0, Future Sep 8, 2023
@ivmartel ivmartel changed the title Use DICOM Presentation State to store state Use DICOM to store state May 15, 2024
@ivmartel ivmartel modified the milestones: Future, 0.34.0 Jun 17, 2024
@ivmartel ivmartel changed the title Use DICOM to store state Use DICOM to store annotations Sep 12, 2024
@ivmartel
Copy link
Owner Author

The plan for now is to first store annotations as DICOM SR and then store state as presentation state. This issue is for the first part, saving annotations. See progress on the related branch.

@ivmartel
Copy link
Owner Author

The possible shapes are limited by the possible values of the GraphicType type tag (00700023 on innolitics) ie POINT, MULTIPOINT, POLYLINE, CIRCLE and ELLIPSE (for 2D). That means that the freehand tool does not have a possible value, a possible replacement being a segmentation for this kind of complex shape.

So, unless somebody complains, this tool will not be reimplemented in the SR implementation.

@ivmartel
Copy link
Owner Author

ivmartel commented Oct 2, 2024

Regarding the old state format, the plan is to support its loading but all code that allowed to save them will be removed. Remember that the old state was not as precise as the DICOM SR, its relation to the 'reference' data was very loose and there was no real guaranty for shapes drawn on oriented views.

@ivmartel ivmartel linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants