Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of Allowing Unknown Images directory naming #141

Merged

Conversation

unapproachable
Copy link
Contributor

Initial implementation of #74

Allows user to specify where Unknown date files go via a command line parameter. Parameter --no-date-dir overrides the default of "unknown".

Usage:

phockup INPUTDIR OUTPUTDIR --no-date-dir=UNKNOWNDIR

Example usage:

phockup ~/Pictures/camera ~/Pictures/sorted --no-date-dir=Miscellaneous

This would put all files without valid EXIF date information in the ~/Pictures/sorted/Miscellaneous directory.

Also included:

  • Added pytest use case named test_no_exif_directory for alternative unknown directory name testing.
  • Refactored phockup constants to the Phockup class ease of scoping for imports and tight coupling to the class.
    DEFAULT_DIR_FORMAT = ['%Y', '%m', '%d']
    DEFAULT_NO_DATE_DIRECTORY = "unknown"
  • Implemented the existing DEFAULT_DIR_FORMAT constant as the fallback case for the --d\--date command line parameter

…own date files go. Parameter --no-date-dir overrides the default of "unknown". Added test case for alternative name.
@unapproachable
Copy link
Contributor Author

I can't/won't correct the Readme violating Flake8 validation. Is there a way to prevent it from being scanned as part of the linting process?

@unapproachable unapproachable changed the title Initial implementation of https://github.com/ivandokov/phockup/issues… Initial implementation of Allowing Unknown Images directory naming Jan 24, 2022
@ivandokov ivandokov merged commit f314a78 into ivandokov:master Mar 13, 2022
@unapproachable unapproachable deleted the feature/unknown_date_folder branch April 2, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants