Added quiet mode to not show output. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandokov
reviewed
Mar 23, 2021
phockup.py
Outdated
| @@ -10,7 +10,7 @@ | |||
| from src.printer import Printer | |||
|
|
|||
|
|
|||
| __version__ = "1.5.26" | |||
| __version__ = "1.5.27" | |||
There was a problem hiding this comment.
Please revert this change as I will be bumping the version with multiple PRs merged. Thanks.
There was a problem hiding this comment.
Oke, revert the version to 1.5.26
src/phockup.py
Outdated
| @@ -140,7 +141,8 @@ def process_file(self, filename): | |||
| if str.endswith(filename, '.xmp'): | |||
| return None | |||
|
|
|||
| printer.line(filename, True) | |||
| if not self.quiet: | |||
There was a problem hiding this comment.
I think all these conditions added for this flag should be passed as a method call to the Printer class and handle the logic to not print anything there. Something like printer.should_print(self.quiet)
There was a problem hiding this comment.
I have also processed this feedback.
unapproachable
pushed a commit
to unapproachable/phockup
that referenced
this pull request
Mar 25, 2021
|
@roykrikke can you please add info about the new flag to the readme. |
ivandokov
added a commit
that referenced
this pull request
Mar 30, 2021
) * Removed for compatibility with Windows * Implemented --maxdepth to limit recursion on input directory Arbitrary limit of 255 set for command line option #92 * Test compatibility for Windows (#102) * Migrated to a more compatible filename for testing exiftool * --Migrated Windows escaping to quoted input rather than shlex.quote escaping. --Added space and punctuation test --Added additional test image * --Updated trailing slash test to use Windows specific slashes on win32 * --Updated trailing slash test to use Windows specific slashes on win32 * --revert unintended commit * Added quiet mode to not show output. (#103) * Arbitrary text change to help to test commits * Updated readme.md with maxdepth details Updated defaults to support --maxdepth=0 to allow processsing only the input directory without any subdirectory traversal. Co-authored-by: roykrikke <[email protected]> Co-authored-by: Ivan Dokov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added option "-q", "--quiet" to run phockup without output. I think this is a useful addition.