Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursivity max depth #92

Closed
anttitelio opened this issue Dec 12, 2020 · 3 comments
Closed

Add recursivity max depth #92

anttitelio opened this issue Dec 12, 2020 · 3 comments

Comments

@anttitelio
Copy link

It seems that by default the application runs the operations for all the sub-directories, which in many cases might not be what the user needs. Could it be possible to add --maxdepth option which would work like on (GNU) Find?

@ivandokov
Copy link
Owner

Sounds like a good feature. All PRs are more than welcome!

@anttitelio
Copy link
Author

Unfortunately I don't have the time nor skills to implement the functionality

unapproachable added a commit to unapproachable/phockup that referenced this issue Mar 25, 2021
Arbitrary limit of 255 set for command line option
ivandokov#92
ivandokov added a commit that referenced this issue Mar 30, 2021
)

* Removed for compatibility with Windows

* Implemented --maxdepth to limit recursion on input directory
Arbitrary limit of 255 set for command line option
#92

* Test compatibility for Windows (#102)

* Migrated to a more compatible filename for testing exiftool

* --Migrated Windows escaping to quoted input rather than shlex.quote escaping.
--Added space and punctuation test
--Added additional test image

* --Updated trailing slash test to use Windows specific slashes on win32

* --Updated trailing slash test to use Windows specific slashes on win32

* --revert unintended commit

* Added quiet mode to not show output. (#103)

* Arbitrary text change to help to test commits

* Updated readme.md with maxdepth details
Updated defaults to support --maxdepth=0 to allow processsing only the input directory without any subdirectory traversal.

Co-authored-by: roykrikke <[email protected]>
Co-authored-by: Ivan Dokov <[email protected]>
@anttitelio
Copy link
Author

That merged issue #104 seems to be completed so this original one must be completed also. Seems to work just like I wanted 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants