Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ext.util.Observable#addEvents" is deprecated. #26

Open
cblack opened this issue Sep 3, 2014 · 8 comments
Open

"Ext.util.Observable#addEvents" is deprecated. #26

cblack opened this issue Sep 3, 2014 · 8 comments

Comments

@cblack
Copy link

cblack commented Sep 3, 2014

Using Ext 5.0.1, you will get the error: "Ext.util.Observable#addEvents" is deprecated.

See this ticket (http://www.sencha.com/forum/showthread.php?198969-Observable-deprecate-addEvents)

"You don't need the addEvents call. The event will get added the first time it's fired, or the first time a listener is added. Whichever comes first."

I just commented out the addEvent calls to make it work.

You can follow their suggested method of documenting the events like so:

/**
 * @event submit
 * @preventable doSubmit
 * Fires upon successful (Ajax-based) form submission
 * @param {Ext.form.Panel} this This FormPanel
 * @param {Object} result The result object as returned by the server
 * @param {Ext.EventObject} e The event object
 */
@ivan-novakov
Copy link
Owner

You are right. That piece of code is there since the addEvents was beeing used :).
And I haven't tested the widget with Ext JS 5 yet, I doesn't expect it to work without some modifications.

@tvaughan73
Copy link

What do I need to do in order to get this to work with Ext JS 5?

@stitcherooni
Copy link

I'd be very interested in seeing this project modified to work with Ext JS 5.

@Grey2k
Copy link

Grey2k commented Nov 14, 2014

im working on it. soon it will be availible ...

about Ext.util.Observable#addEvents" is deprecated. ... just remove it - in ExtJS 5 - Events added automatically

@Misiu
Copy link

Misiu commented Dec 15, 2014

@Grey2k, @ivan-novakov any chances there will be ExtJS5 version in near future?

@tvaughan73
Copy link

so, all i should have to do is remove addEvents from all files?

@Grey2k
Copy link

Grey2k commented Dec 20, 2014

yep )

@Grey2k
Copy link

Grey2k commented Mar 2, 2015

Gyus - its almost done ) Today i start tested it in production and soon make the resease.

its will work only on ExtJS > 5.0.2 cause this bug

selModel : Ext.create('Ext.selection.CheckboxModel', {
                checkOnly: true, // not working 
});

http://www.sencha.com/forum/showthread.php?290630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants