[Bug] Error message isn't HTML escaped

[saltycrys]

The error message isn't HTML escaped, leading to messages like #1755.

Route: /feed/trending?type=News®ion=US

should be

Route: /feed/trending?type=News&region=US

---

The error message is created here:

invidious/src/invidious/helpers/errors.cr

Lines 25 to 44 in b29e60a

	def error_template_helper(env : HTTP::Server::Context, locale : Hash(String, JSON::Any) | Nil, status_code : Int32, exception : Exception)
	if exception.is_a?(InfoException)
	return error_template_helper(env, locale, status_code, exception.message || "")
	end
	env.response.content_type = "text/html"
	env.response.status_code = status_code
	issue_template = %(Title: `#{exception.message} (#{exception.class})`)
	issue_template += %(\nDate: `#{Time::Format::ISO_8601_DATE_TIME.format(Time.utc)}`)
	issue_template += %(\nRoute: `#{env.request.resource}`)
	issue_template += %(\nVersion: `#{SOFTWARE["version"]} @ #{SOFTWARE["branch"]}`)
	# issue_template += github_details("Preferences", env.get("preferences").as(Preferences).to_pretty_json)
	issue_template += github_details("Backtrace", exception.inspect_with_backtrace)
	error_message = <<-END_HTML
	Looks like you've found a bug in Invidious. Please open a new issue
	<a href="https://github.com/iv-org/invidious/issues">on GitHub</a>
	and include the following text in your message:
	<pre style="padding: 20px; background: rgba(0, 0, 0, 0.12345);">#{issue_template}</pre>
	END_HTML
	return templated "error"
	end

See https://crystal-lang.org/api/0.35.1/HTML.html#escape(string:String):String-class-method

[hackerncoder]

Don't you mean #1755

[saltycrys]

Don't you mean #1755

Yes, thank you.

[hackerncoder]

#1838 Is another one that shows this problem.