Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add forwardref support #74

Merged
merged 1 commit into from
Sep 24, 2023
Merged

fix: add forwardref support #74

merged 1 commit into from
Sep 24, 2023

Conversation

jrson83
Copy link
Collaborator

@jrson83 jrson83 commented Sep 23, 2023

closes #51

@jrson83 jrson83 requested a review from itsjavi as a code owner September 23, 2023 23:53
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (051f22f) 2.76% compared to head (094b875) 2.73%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #74      +/-   ##
========================================
- Coverage   2.76%   2.73%   -0.03%     
========================================
  Files         44      45       +1     
  Lines       2786    2811      +25     
  Branches      57      58       +1     
========================================
  Hits          77      77              
- Misses      2666    2690      +24     
- Partials      43      44       +1     
Files Changed Coverage Δ
...examples/react/src/components/ForwardRefButton.tsx 0.00% <0.00%> (ø)
packages/storylite/src/types/components.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@itsjavi itsjavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! we are depending on React but I think that it's acceptable for now until we add support for other frameworks, it's still good to have these abstracted types (so the refactoring will be easier).

@itsjavi itsjavi merged commit d88a77a into main Sep 24, 2023
1 of 3 checks passed
@itsjavi itsjavi deleted the fix/componentprops branch September 24, 2023 13:51
@jrson83
Copy link
Collaborator Author

jrson83 commented Sep 24, 2023

great! we are depending on React but I think that it's acceptable for now until we add support for other frameworks, it's still good to have these abstracted types (so the refactoring will be easier).

Yes, for me it was important to have forwardRef working asap, cause I do not want to refactor all my components again.
It took me quite a while and there maybe room for improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[bug] Typescript support for components using forwardRef
2 participants