telemetry: remove unnecessary error from payload

[casperdcl]

Same as iterative/cml#1236

terraform-provider-iterative/iterative/utils/analytics.go

Lines 319 to 355 in d53e68f

	err := ""
	if e != nil {
	err = reflect.TypeOf(e).String()
	}
	userId, uErr := UserId()
	if uErr != nil {
	return nil, uErr
	}
	groupId, gErr := GroupId()
	if gErr != nil {
	return nil, gErr
	}
	tfVer, tfVerErr := TerraformVersion()
	if tfVerErr != nil {
	return nil, tfVerErr
	}
	extra["ci"] = guessCI()
	extra["terraform_version"] = tfVer
	payload := map[string]interface{}{
	"user_id": userId,
	"group_id": groupId,
	"action": action,
	"interface": "cli",
	"tool_name": "tpi",
	"tool_source": "terraform",
	"tool_version": Version,
	"os_name": systemInfo["os_name"],
	"os_version": systemInfo["platform_version"],
	"backend": extra["cloud"],
	"error": err,
	"extra": extra,
	}

instead logic should be:

 if e != nil { 
 	payload["error"] = reflect.TypeOf(e).String()
 } // otherwise, "error" should not appear in payload