Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the AWS VPC architecture #107

Closed
0x2b3bfa0 opened this issue Apr 30, 2021 · 6 comments
Closed

Improve the AWS VPC architecture #107

0x2b3bfa0 opened this issue Apr 30, 2021 · 6 comments
Labels
enhancement New feature or request network resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Apr 30, 2021

(Follow-up of iterative/cml#484)

We're using the first VPC and the first subnet to deploy EC2 instances, but this behavior can be problematic in some cases.

We can either create a new VPC as part of the provisioning process or just allow users to specify which one should be used. The first solution could be more transparent for users and allow us to keep the common interface as pure as possible.

@haviland-nh
Copy link

First posting here!

Just wanted to add an upvote here to provide VPC and Subnet as a parameter. I think this feature would add flexibility to the provider, without requiring it to do more than it has to.

@DavidGOrtega DavidGOrtega changed the title Improve the AWS VPC integration Network resource Jun 3, 2021
@DavidGOrtega DavidGOrtega changed the title Network resource Improve the AWS VPC integration Jun 3, 2021
@DavidGOrtega DavidGOrtega changed the title Improve the AWS VPC integration Network resource - Improve the AWS VPC integration Jun 3, 2021
@DavidGOrtega
Copy link
Contributor

DavidGOrtega commented Jun 3, 2021

We have to create the network resource. This is not new actually nor anything that we have decided recently. In the very beginning the provider needed to have two additional resources:

  • Network
  • Volumes

The network resource will be a very simple network abstraction on top of the cloud vendors. The goal is to have like CML a very yet powerful implementation and the major goal to solve here for ML purposes is the need to create clusters of machines that allow us to do distributed training.
Achieving that goal we will also provide that reusable network where all the basic needs are going to be covered, similar to any cloud vendor capabilities.

@0x2b3bfa0 0x2b3bfa0 added network and removed cloud-aws Amazon Web Services labels Jun 3, 2021
@0x2b3bfa0 0x2b3bfa0 mentioned this issue Jun 3, 2021
4 tasks
@0x2b3bfa0
Copy link
Member Author

Closing in favor of #123 and children

@0x2b3bfa0 0x2b3bfa0 changed the title Network resource - Improve the AWS VPC integration Improve the AWS VPC architecture Jun 3, 2021
@0x2b3bfa0 0x2b3bfa0 reopened this Jun 3, 2021
@0x2b3bfa0
Copy link
Member Author

Reopening after the organization, related to (but not mixed with) #124

@0x2b3bfa0 0x2b3bfa0 added resource-runner iterative_runner TF resource resource-machine iterative_machine TF resource labels Apr 24, 2022
@dacbd
Copy link
Contributor

dacbd commented Apr 24, 2022

I think we can close this, a target vpc can be selected with aws_security_group and a target subnet with aws_subnet_id

perhaps a larger "networking" issue exists so that this can functionally exist with gcp/az @0x2b3bfa0 ?

@0x2b3bfa0
Copy link
Member Author

Related to #289 and #299; more specifically to making use of existing resources.

Yes, we can close this for the reasons you mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request network resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource
Projects
None yet
Development

No branches or pull requests

4 participants