Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build mechanism #24

Closed
DavidGOrtega opened this issue Mar 4, 2021 · 3 comments
Closed

Build mechanism #24

DavidGOrtega opened this issue Mar 4, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@DavidGOrtega
Copy link
Contributor

Github actions needs by convention to override the mayor version doing a forced push.
Now it's done manually and should be done in the CI when merging into master.

@DavidGOrtega DavidGOrtega self-assigned this Mar 4, 2021
@0x2b3bfa0
Copy link
Member

Perhaps related to #31 and the infamous iterative/setup-dvc#12, because of the automatic major tagging system:

uses: Actions-R-Us/actions-tagger@v2
env:
  GITHUB_TOKEN: ${{ github.token }}
with:
  publish_latest_tag: true

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Sep 17, 2021

Quote from @casperdcl #42 (comment)

The tagging approach for actions is very different from tags on normal repos.

You need git tag v1.x.x && git tag -f v1 && git push --tags -f

I would suggest:

  • closing this PR unmerged
  • rename master to v1 and use a hybrid of
    • branch approach for actions for major (i.e. @v1, @v2) pointers
    • tags for semver (i.e. @v1.x.x) pointers
      • ideally start writing release notes for these but accept that no workflow.yml file can enforce this

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Sep 17, 2021

🔔 @iterative/cml, does anybody dislike this approach? In the meanwhile, I'm going to request again ⚡ permissions on the almighty #infrastrutcure channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants