Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

mlem.api.save fs argument type #271

Closed
mike0sv opened this issue May 27, 2022 · 1 comment · Fixed by #426
Closed

mlem.api.save fs argument type #271

mike0sv opened this issue May 27, 2022 · 1 comment · Fixed by #426
Assignees
Labels
🏡 housekeeping Fighting technical debt and improving dev process
Milestone

Comments

@mike0sv
Copy link
Contributor

mike0sv commented May 27, 2022

Now it's Union[str, AbstractFileSystem, None]. But underlying implementation (in MlemObject._parse_dump_args) has it as Optional[AbstractFileSystem]. Need to either include str there (and corresponding logic) or remove str from save signature

@aguschin aguschin added the 🏡 housekeeping Fighting technical debt and improving dev process label May 31, 2022
@mike0sv mike0sv added this to the Q3 milestone Jun 1, 2022
@madhur-tandon
Copy link
Contributor

we can just remove src from save signature?
Just did that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏡 housekeeping Fighting technical debt and improving dev process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants