Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

prism: we need both dvc and mlem highlighters #59

Closed
jorgeorpinel opened this issue May 17, 2022 · 17 comments
Closed

prism: we need both dvc and mlem highlighters #59

jorgeorpinel opened this issue May 17, 2022 · 17 comments
Labels
dependencies Pull requests that update a dependency file p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@jorgeorpinel
Copy link
Contributor

Originally posted by @jorgeorpinel in #43 (comment)

@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions p1-important Active priorities to deal within next sprints dependencies Pull requests that update a dependency file labels May 17, 2022
@jorgeorpinel
Copy link
Contributor Author

Cc @rogermparent @julieg18 👋🏼

@jorgeorpinel jorgeorpinel mentioned this issue May 17, 2022
1 task
@jorgeorpinel
Copy link
Contributor Author

Also usage. Maybe that one should be part of the docs engine repo itself?

@rogermparent
Copy link
Contributor

We have usage, dvc, and dvctable in the theme repo already. It's likely we'll include highlighters for all our tools considering cross-tool usage is an important feature of all of them.

@jorgeorpinel

This comment was marked as resolved.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 18, 2022

we'll include highlighters for all our tools considering cross-tool usage

Makes sense. We could even combine dvc and mlem since all that changes are the actual (sub)commands. Would be good to keep both names available (for the same highlighter) though, so you can include mlem commands in dvc blocks and vice versa.

But will this be sustainable? Consider a growing number of tools e.g. cml (rel. iterative/cml.dev#239), gto, ldb, etc.

I suspect the main integration is from everything to DVC so another option is to have dvc in the doc engine repo and somehow extend it in each product repo to add their commands.

@shcheklein
Copy link
Member

I also think that we need one CLI highlighter ... I wonder if should even use something generic like cli

@yathomasi
Copy link
Contributor

yathomasi commented May 19, 2022

I also think that we need one CLI highlighter ... I wonder if should even use something generic like cli

I was also thinking, if we could use a generic highlighter like cli for all of the tools that highlights dvc, cml or mlem. Of course, we already have git and bash command so this generic option will make it easier, and consistent to use.

@yathomasi
Copy link
Contributor

Proposal PR

  • Supporting mlem commands
  • Generic language cli for highlighting dvc, cml, mlem
  • dvc still works(only dvc) and can be thought of as alias to cli
    • keeping it so it wouldn't break dvc.org

What do we think of a color for highlighting? Currently, we are using the same color for all the tools.

@shcheklein
Copy link
Member

@yathomasi looks good to me! Same color is also fine to my mind.

@jorgeorpinel
Copy link
Contributor Author

I can't see the gatsby-theme-iterative repo but sounds good.

@casperdcl
Copy link

casperdcl commented May 20, 2022

About the Proposal PR - what about git? To me it's part of the dvc/cml/mlem group.

@yathomasi
Copy link
Contributor

About the Proposal PR - what about git? To me it's part of the dvc/cml/mlem group.

git, bash commands will also be covered with generic cli language. So, I think it's going to be easier for us to maintain and use.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 25, 2022

Question 1: this is already implemented in this repo right? I see correct highlighting in blocks all over https://mlem.ai/doc.

Question 2: What about Windows (cmd)? That also qualifies as "CLI". At least in DVC.org we try to are a little about Windows users (example).

@yathomasi
Copy link
Contributor

Question 1: this is already implemented in this repo right? I see correct highlighting in blocks all over https://mlem.ai/doc.

Yes, it's already available to the repo #45.

Question 2: What about Windows (cmd)? That also qualifies as "CLI". At least in DVC.org we try to are a little about Windows users (example).

It's working with dvc highlighter, so cli also should be covering them as well.

@yathomasi
Copy link
Contributor

With the #81 merged, syntax highlighting for tools should be available through generic cli.

@casperdcl
Copy link

@yathomasi can we have this ported to cml.dev too? 🙏

@yathomasi
Copy link
Contributor

@yathomasi can we have this ported to cml.dev too? 🙏

@casperdcl It's already available.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

5 participants