Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dvcx): Add pythonUserBase path to DVCx worker config #313

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

mjasion
Copy link
Contributor

@mjasion mjasion commented Feb 13, 2024

This update introduces a new parameter, pythonUserBase, to the DVCx worker configuration. This allows customization of the base path for user site-packages. By default the location is changed from ~/.local to /tmp/.pip/local, where ephemeralStorage is beeing used.

Pip docs: https://pip.pypa.io/en/stable/user_guide/#user-installs

Closes https://github.com/iterative/itops/issues/3636

#305, which caused a bug similar to bitnami/charts#20504
the whole bitami/charts repository introduced breaking changes, causing the issue. Probably, there is a need for upgrading redis & postgres in one PR.

@mjasion mjasion requested review from dreadatour and a team February 13, 2024 19:25
@mjasion mjasion self-assigned this Feb 13, 2024
@mjasion mjasion changed the title feat(dvcx): Add pythonUserBase path to DVCx worker config feat(dvcx): Add pythonUserBase path to DVCx worker config Feb 13, 2024
This update introduces a new parameter, `pythonUserBase`, to the DVCx worker configuration. This allows customization of the base path for user site-packages. By default the location is changed from `~/.loacal` to `/tmp/.pip/local`, where ephemeralStorage is beeing used.
@mjasion mjasion force-pushed the configure_python_userbase_in_dvcx branch from d441bd1 to 1026078 Compare February 14, 2024 06:53
Copy link
Contributor

@dreadatour dreadatour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mjasion mjasion force-pushed the configure_python_userbase_in_dvcx branch from 9a1a75d to 1026078 Compare February 14, 2024 11:08
@mjasion mjasion force-pushed the configure_python_userbase_in_dvcx branch from c611c37 to e69c6ee Compare February 14, 2024 11:42
@mjasion
Copy link
Contributor Author

mjasion commented Feb 14, 2024

I had to revert #305, which caused a bug similar to bitnami/charts#20504
the whole bitami/charts repository introduced breaking changes, causing the issue. Probably, there is a need for upgrading redis & postgres in one PR.

@mjasion mjasion requested a review from jesper7 February 14, 2024 11:47
@mjasion mjasion added this pull request to the merge queue Feb 14, 2024
@mjasion mjasion removed this pull request from the merge queue due to a manual request Feb 14, 2024
@mjasion mjasion added this pull request to the merge queue Feb 14, 2024
@mjasion mjasion removed this pull request from the merge queue due to the queue being cleared Feb 14, 2024
@mjasion mjasion merged commit 7d36dab into main Feb 14, 2024
4 checks passed
@mjasion mjasion deleted the configure_python_userbase_in_dvcx branch February 14, 2024 12:39
mjasion added a commit that referenced this pull request Feb 16, 2024
mjasion added a commit that referenced this pull request Feb 16, 2024
mjasion added a commit that referenced this pull request Feb 19, 2024
mjasion added a commit that referenced this pull request Feb 19, 2024
* Revert "feat(dvcx): Add `pythonUserBase` path to DVCx worker config (#313)"

This reverts commit 7d36dab.

* Bump Chart.yaml

---------

Co-authored-by: Marcin Jasion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants