-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dvcx): Add pythonUserBase
path to DVCx worker config
#313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjasion
changed the title
feat(dvcx): Add pythonUserBase path to DVCx worker config
feat(dvcx): Add Feb 13, 2024
pythonUserBase
path to DVCx worker config
dreadatour
reviewed
Feb 14, 2024
This update introduces a new parameter, `pythonUserBase`, to the DVCx worker configuration. This allows customization of the base path for user site-packages. By default the location is changed from `~/.loacal` to `/tmp/.pip/local`, where ephemeralStorage is beeing used.
mjasion
force-pushed
the
configure_python_userbase_in_dvcx
branch
from
February 14, 2024 06:53
d441bd1
to
1026078
Compare
dreadatour
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
mjasion
force-pushed
the
configure_python_userbase_in_dvcx
branch
from
February 14, 2024 11:08
9a1a75d
to
1026078
Compare
jesper7
approved these changes
Feb 14, 2024
mjasion
force-pushed
the
configure_python_userbase_in_dvcx
branch
from
February 14, 2024 11:42
c611c37
to
e69c6ee
Compare
I had to revert #305, which caused a bug similar to bitnami/charts#20504 |
jesper7
approved these changes
Feb 14, 2024
0x2b3bfa0
approved these changes
Feb 14, 2024
mjasion
added a commit
that referenced
this pull request
Feb 19, 2024
* Revert "feat(dvcx): Add `pythonUserBase` path to DVCx worker config (#313)" This reverts commit 7d36dab. * Bump Chart.yaml --------- Co-authored-by: Marcin Jasion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a new parameter,
pythonUserBase
, to the DVCx worker configuration. This allows customization of the base path for user site-packages. By default the location is changed from~/.local
to/tmp/.pip/local
, where ephemeralStorage is beeing used.Pip docs: https://pip.pypa.io/en/stable/user_guide/#user-installs
Closes https://github.com/iterative/itops/issues/3636
#305, which caused a bug similar to bitnami/charts#20504
the whole
bitami/charts
repository introduced breaking changes, causing the issue. Probably, there is a need for upgradingredis
&postgres
in one PR.