Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab sync not working #92

Closed
casperdcl opened this issue Oct 4, 2022 · 4 comments · Fixed by #94
Closed

tab sync not working #92

casperdcl opened this issue Oct 4, 2022 · 4 comments · Fixed by #94
Assignees
Labels
A: website Website development enhancement New feature or request p1-important 🐛 type: bug Something isn't working.

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Oct 4, 2022

e.g. go to "Allocating Cloud Compute Resources with CML", click GitLab, then scroll down to "Environment Variables" -- which will be stuck on GitHub still

/CC @iterative/websites

@casperdcl casperdcl added the A: website Website development label Oct 4, 2022
@casperdcl casperdcl changed the title tab not working tab sync not working Oct 4, 2022
@jorgeorpinel
Copy link

jorgeorpinel commented Oct 12, 2022

Interesting. I see tab groups as independent so it's unclear that they should all change when you change one. Maybe we need a new prop in there such as group="GH" or something to link them together.

The funny behavior now has to do with the permalink though, because if you load the page with ?tab=Bitbucket it will change all of the tab groups to that tab, not just the one you changed before copying the link. Not sure how to address that (seems minor though).

@jorgeorpinel jorgeorpinel added the enhancement New feature or request label Oct 12, 2022
@jorgeorpinel
Copy link

jorgeorpinel commented Oct 12, 2022

I don't think tab sync was ever a feature so should we consider this a feature request? I can second it.

We may also want to move to the engine repo.

@julieg18
Copy link
Contributor

I don't think tab sync was ever a feature so should we consider this a feature request? I can second it.

Definitely was a feature at one point! I remember building it :)

Feel free to migrate to https://github.com/iterative/gatsby-theme-iterative/ if required.

Makes sense for it to be in gatsby-theme-iterative since all the code for the tabs is in the theme!

@julieg18 julieg18 transferred this issue from iterative/cml.dev Oct 12, 2022
@jorgeorpinel jorgeorpinel added the 🐛 type: bug Something isn't working. label Oct 12, 2022
@casperdcl
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Website development enhancement New feature or request p1-important 🐛 type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants