Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get EV code signing certificate to sign our binary packages #936

Closed
efiop opened this issue Jul 22, 2018 · 4 comments
Closed

Get EV code signing certificate to sign our binary packages #936

efiop opened this issue Jul 22, 2018 · 4 comments
Assignees
Labels
enhancement Enhances DVC
Milestone

Comments

@efiop
Copy link
Contributor

efiop commented Jul 22, 2018

I.e. https://www.certum.eu/en/cert_offer_microsoft_code_signing/ .

The "untrusted source" window is annoying, but it is only a small part of the problem. A much bigger problem is that when you install dvc from binary windows package, windows defender thinks that this is a virus and makes it extremely slow. To fix that we need to sign our packages with a trusted certificate.

@efiop efiop added the enhancement Enhances DVC label Jul 22, 2018
@efiop efiop added this to the Queue milestone Jul 22, 2018
@efiop
Copy link
Contributor Author

efiop commented Dec 18, 2018

No longer needed after #1447 , since we no longer build a single binary and all binaries in --onedir are already signed.

@efiop efiop closed this as completed Dec 18, 2018
@efiop
Copy link
Contributor Author

efiop commented Dec 19, 2018

Reopenning since we still need this for our installers.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Apr 1, 2020

Just want to post what this looks like on Windwos. The installer is stopped by Windows Defender with a "Windows protected your PC" screen:

image

You need to click "More info" to be able to use the [Run anyway] button:

image

p.s. similar to #2677 on Mac

@efiop
Copy link
Contributor Author

efiop commented Mar 18, 2021

For the record:

  • rpm and deb
  • mac pkg
  • windows with OV cert for simplicity, but at least it is no longer "Unknown publisher". It should get better the more people install it, smartscreen will learn to trust this cert (will build up reputation).
    Screenshot from 2021-04-06 06-56-02

@efiop efiop self-assigned this Mar 18, 2021
@efiop efiop closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

No branches or pull requests

3 participants