Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permanent deletion config for versioned S3 repositories during garbage collection #5269

Closed
charlesmelby opened this issue Jan 14, 2021 · 3 comments
Labels
feature request Requesting a new feature p3-nice-to-have It should be done this or next sprint

Comments

@charlesmelby
Copy link

When working with data involving restrictions (e.g. personal information), it is often necessary to be able to delete it at a later date.

If the data has to go onto an S3 bucket with versioning enabled (the situation I'm in now), garbage collection only adds a delete marker, and the data can still be recovered.

I would like to propose adding a config option for S3 remotes that enables permanent deletion.
When set on a versioned remote, any object deleted during garbage collection would be deleted permanently.

Apparently permanent deletion can be done with boto3, e.g.
https://stackoverflow.com/questions/46819590/delete-all-versions-of-an-object-in-s3-using-python/53872419#53872419

@efiop
Copy link
Contributor

efiop commented Jan 14, 2021

@efiop efiop added feature request Requesting a new feature p3-nice-to-have It should be done this or next sprint labels Jan 14, 2021
@skshetry
Copy link
Member

skshetry commented Jan 3, 2023

This may be potentially out of scope for DVC. cc @dberenbaum.

@dberenbaum
Copy link
Collaborator

Good thought @skshetry, but given our increased support for cloud versioning, I think this one is likely to be a need when doing gc on cloud-versioned remotes. cc @pmrowla

@mattseddon mattseddon closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requesting a new feature p3-nice-to-have It should be done this or next sprint
Projects
None yet
Development

No branches or pull requests

5 participants