Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache dirs when using gc #3375

Closed
pared opened this issue Feb 21, 2020 · 1 comment
Closed

Remove cache dirs when using gc #3375

pared opened this issue Feb 21, 2020 · 1 comment
Labels
bug Did we break something? p3-nice-to-have It should be done this or next sprint

Comments

@pared
Copy link
Contributor

pared commented Feb 21, 2020

Please provide information about your setup
DVC version(i.e. dvc --version), Platform and method of installation (pip, homebrew, pkg Mac, exe (Windows), DEB(Linux), RPM(Linux))

Reproduction script:

#!/bin/bash

rm -rf repo
mkdir repo

pushd repo
git init --quiet
dvc init -q
set -ex

git add -A
git commit -am "init"

echo data1>>data
dvc add data
git add -A 
git commit -am "first commit"

rm data
echo data2>>data
dvc add data
git commit -am "second commit"
git tag v1

rm data
echo data3>>data
dvc add data

dvc gc --all-tags
tree .dvc/cache

gc succesfully removes data from cache, but does not check whether parent dir of file in cache is empty and leave it even if it was empty. We should remove that parent dir if there is no other file inside.

EDIT:
expected output of tree should not contain empty directory in cache.

@skshetry
Copy link
Member

skshetry commented Jul 4, 2023

Closing as wontfix.

@skshetry skshetry closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? p3-nice-to-have It should be done this or next sprint
Projects
None yet
Development

No branches or pull requests

2 participants