Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending query params shows 404 page #909

Closed
skshetry opened this issue Jan 9, 2020 · 1 comment
Closed

Appending query params shows 404 page #909

skshetry opened this issue Jan 9, 2020 · 1 comment

Comments

@skshetry
Copy link
Member

skshetry commented Jan 9, 2020

Steps to reproduce

  1. Open https://dvc.org/doc. It loads correctly.
  2. Open https://dvc.org/doc?query=params. 404 page is returned.

This happens on all documentation links I tried, not just /doc.

Note: Some sites like facebook add a tracking code as a query param (via ?fbclid=<id>), so, this makes the documentation links shared on such sites unusable.

@shcheklein
Copy link
Member

Fixed, thanks @skshetry !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants