Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc sidebar menu on mobile, don't close it on navigate #808

Closed
Suor opened this issue Nov 20, 2019 · 10 comments · Fixed by #1279
Closed

doc sidebar menu on mobile, don't close it on navigate #808

Suor opened this issue Nov 20, 2019 · 10 comments · Fixed by #1279
Labels
A: website Area: website p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc website: ux Website UI/UX

Comments

@Suor
Copy link
Contributor

Suor commented Nov 20, 2019

On main page there is no top menu, so no way to go into docs unless you type it into address field

Additionally, to switch to a submenu of other than currently open menu you need to open menu twice:

  • open menu
  • hit top level item
  • it closes
  • open menu
  • hit next level item
@shcheklein
Copy link
Member

@Suor The is a "burger" top menu already that has docs in it or am I missing the point of the issue?

@shcheklein shcheklein added the A: docs Area: user documentation (gatsby-theme-iterative) label Nov 20, 2019
@shcheklein shcheklein changed the title Mobile website issues mobile website issues Nov 20, 2019
@shcheklein shcheklein added the website: eng-doc DEPRECATED JS engine for /doc label Nov 20, 2019
@Suor
Copy link
Contributor Author

Suor commented Nov 20, 2019

@shcheklein the burger top menu shows the bottom plate. Maybe it shouldn't?

@shcheklein
Copy link
Member

@Suor but it has Docs in it, right? To be precise - it has everything we would need to show?

@Suor
Copy link
Contributor Author

Suor commented Nov 20, 2019

@shcheklein No it has nothing we need to show, it is the bottom plate.
dvc-org-bottom-burger

@shcheklein
Copy link
Member

How about the Documenation link right in the center?

@Suor
Copy link
Contributor Author

Suor commented Nov 20, 2019

:) I looked at it several times and didn't see it until you mentioned. Maybe my internal adblock is just too strong. Or maybe it's a broken expectation - I expect grey text on white saying "docs", I expected menu not a plate.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 20, 2019

This seems like a UI/UX decision more than anything else. I personally have nothing against showing the footer in the burger menu but I would then hide the footer from mobile view when you scroll down. Who knows. Need a designer

@shcheklein
Copy link
Member

Kk, we can definitely redesign it a bit. I would inverse colors for example as a first step.

@shcheklein shcheklein added website: design Website graphic design type: enhancement Something is not clear, small updates, improvement suggestions labels Nov 20, 2019
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 21, 2019

I left your idea an inverted thumbs up, Ivan.

@jorgeorpinel jorgeorpinel added mobile A: website Area: website and removed A: docs Area: user documentation (gatsby-theme-iterative) website: eng-doc DEPRECATED JS engine for /doc labels Jan 19, 2020
@jorgeorpinel jorgeorpinel changed the title mobile website issues ui: mobile website issues Jan 19, 2020
@shcheklein shcheklein changed the title ui: mobile website issues ui: doc menu on mobile, don't close it on navigate Apr 9, 2020
@shcheklein shcheklein added website: eng-doc DEPRECATED JS engine for /doc p1-important Active priorities to deal within next sprints and removed A: website Area: website labels Apr 9, 2020
@shcheklein
Copy link
Member

Repurposed this to focus on docs menu issues only. Burger top menu has been redesigned.

@shcheklein shcheklein changed the title ui: doc menu on mobile, don't close it on navigate doc sidebar menu on mobile, don't close it on navigate Apr 9, 2020
@shcheklein shcheklein added website: ux Website UI/UX A: website Area: website and removed website: design Website graphic design labels Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc website: ux Website UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants