Edit on Github button seems to be broken

[shcheklein]

I detected this trough the Hexometer monitoring:

Let's do a postmortem and analyze how could we improve this. Seems like the right way is to pay more attention to the link checker ? we need to see if it was able to detect this in the first place.

[shcheklein]

[rogermparent]

Thanks @julieg18 for the fix! This was wholly on me because I made a typo in moving the logic for generating GitHub links: I set the repo as iterative/dvc instead of iterative/dvc.org

Seems like the right way is to pay more attention to the link checker ?

The PR link checker wouldn't have caught this, as it only inspects sources, and I'm pretty sure the whole-site checker does as well. The resulting links from these "edit on GitHub" buttons are only ever put together dynamically at the end of the process with a template string, so the link checker never reads them.

[rogermparent]

Just merged the fix PR and made sure the buttons work, and they do!