-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise experiments docs? #2266
Comments
In #2243 (comment), I mentioned that the differences between Here's the intro to the getting started doc:
That intro raises questions:
An alternative approach would be more explicit. For example:
|
@dberenbaum thanks for creating this ticket to do another round of reviews and improvements. A few notes from me (I haven't had time to review some parts of the docs though). Strategic points:
Tactics:
Also, a meta discussion :) it might make sense to even create a separate ticket per checkbox (and link those in the list in this ticket), otherwise it seems it will be hard to discuss so many points in this single thread? |
I made separate issues for each strategic point. I realized this probably isn't quite what you meant @shcheklein, but maybe it's better to think about our docs as products and focus the issues on each product instead of technical questions. Here's a checklist for the strategic points(see links to the issues above):
|
totally agree! it's just sometimes it's hard to define the line - docs itself is a product (that we have Get Started, Use Cases, User Guide, Cmd Ref in the first place), then each section can be potentially a product (but we should keep in mind other sections and decisions made there). Not pushing to any actions here, just sharing my experience. I'm totally fine to try to iterate in a way you suggested.
yeah, I had in mind probably tactical points (like should we use a specific term or not) - so that we don't discuss all them simultaneously in one place (it's hard to do on GH in a single ticket). We can actually try to use GH discussions for this? |
Yeah, after thinking about it more, I thought we might need to address those strategic points before getting to the tactics. If we want to make major changes to some of the docs, not worth getting caught in the details now. It would be great to propose what we expect from each doc before starting it or revising it. That was the hope with the new issues (once they get more fleshed out), but maybe it would be better in something like Notion, Google Drive, a markdown file in a PR for comment, etc.
Good idea. I was just looking at those today and thinking about when they might be useful instead of issues. I'll probably try that once we get a better sense of the strategic points. |
Any mechanism works for me personally (I would be happy to keep on GH for public visibility, but it can be too painful? not sure. though RFC PR sounds like an option? may be GH discussions? may be our forum - discuss.dvc.org?) |
I got intrigued seeing some of the great proposals from our users, like https://www.notion.so/Change-dvc-lock-hashes-eb027be2df044ce382183a14718ec48b 😄 , but I agree that GH is great to keep public visibility and public comment. |
@shcheklein @jorgeorpinel Interested in your thoughts on the structure of #2268 so that I can decide whether to do something similar for the other issues. Of course, please also provide any feedback on the substance in the issue itself. |
@dberenbaum on that specifically,
I'll update docs per #2243 (comment) but there's also a possible core prod discussion on this, I think: why not let users do Any other specific overlaps you think we can ameliorate with docs?
I hope "persistent" is a general-enough term that doesn't need a special definition but we can make a tooltip if needed in those cases. Any other special terms you've detected?
The docs sections are meant to have different perspectives though, keeping in mind website traffic funnels can start in any page (which unfort we haven't studied well enough yet). Let's def. address any specific inconsistencies though.
We try not to go into implementation details except very carefully (often hidden), as probably only very few users can get value from that. It may not help most people understand, but it can scare them off. Also, implementation can change much more often than high-level futures or even the UI so tech details make docs harder to maintain. We also have GH tickets, support history, and the codebase itself for that (different types of docs).
That struct is great for discussions but may need significant updates or further breaking down into smaller actionable tasks (and keep it readable in the future if it lingers). 💡 We can also consider enabling Discussions in this repo instead BTW, if we start treating docs sections more as products or prod features. I've left more specific comments in the sub-issues here. @dberenbaum feel free to summarize what is still pending to decide for this parent ticket. Or if you intend to keep it as "epic" there's actually a label for that (feel free to apply it). Thanks |
Thanks, @jorgeorpinel! I'll keep it as an epic then for now and keep actual discussion in this issue to a minimum. |
This may have been overly ambitious 🤣 . Thoughts on closing this and the related issues for now? We could always reopen if we prioritize them in the future. |
@dberenbaum no concerns on my end, we can discuss the priorities for the next iteration together. |
Using this ticket to discuss experiments docs, with a focus on:
Clarity - Experiments have a lot of overlap with other commands in both DVC and Git (for example,
dvc exp run
compared todvc run
anddvc repro
). Someexp
commands also have overlap with each other (for example,apply
andbranch
). There are also certain keywords that we adopted (for example, "persisting" experiments), but I don't think they are defined anywhere. All of this may both confuse users and obfuscate the value of experiments.Consistency - Experiments are documented in https://dvc.org/doc/command-reference/exp, https://dvc.org/doc/user-guide/experiment-management, and https://dvc.org/doc/start/experiments (and references elsewhere). @pmrowla, @jorgeorpinel, and I wrote these sections separately. Despite collaboration and review, there's are different perspectives and likely inconsistencies.
Now that experiments are an officially released feature, we can gather any feedback from users and discuss here.
The text was updated successfully, but these errors were encountered: