Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not fail on unused imports #1291

Closed
rogermparent opened this issue May 14, 2020 · 0 comments · Fixed by #1744
Closed

CI does not fail on unused imports #1291

rogermparent opened this issue May 14, 2020 · 0 comments · Fixed by #1744
Assignees
@rogermparent
Labels
A: website Area: website dependencies Pull requests that update a dependency file (automatic) p1-important Active priorities to deal within next sprints

Comments

@rogermparent
Copy link
Contributor

As discovered and discussed here, CI doesn't block commits on eslint warnings like unused imports. I ended up discovering some of my own when running yarn lint-ts after all TS issues are solved.

Getting the CI to fail on unused imports would be very nice, but considering that we can work around this by manually running yarn lint-ts I think it deserves a p1 over a p0.

I can work on this, but someone more familiar with our CI may be more effective here.
@rogermparent rogermparent added p1-important Active priorities to deal within next sprints A: website Area: website labels May 14, 2020
@rogermparent rogermparent mentioned this issue May 14, 2020
Merged
@jorgeorpinel jorgeorpinel added the dependencies Pull requests that update a dependency file (automatic) label May 14, 2020
@rogermparent rogermparent self-assigned this Aug 31, 2020
@rogermparent rogermparent mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogermparent rogermparent

Labels
A: website Area: website dependencies Pull requests that update a dependency file (automatic) p1-important Active priorities to deal within next sprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rule change for ESLint to error on unused variables. iterative/dvc.org
2 participants
@jorgeorpinel @rogermparent