Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community page: events expiration date, do not show irrelevant events #1277

Closed
shcheklein opened this issue May 10, 2020 · 3 comments · Fixed by #1281
Closed

community page: events expiration date, do not show irrelevant events #1277

shcheklein opened this issue May 10, 2020 · 3 comments · Fixed by #1281
Assignees
Labels
A: website Area: website p0-critical Affects users in a bad way at the moment type: feature-request DEPRECATED New feature or request

Comments

@shcheklein
Copy link
Member

Introduce expiration date for the main banner and per event for the events section.

If event/banner no relevant anymore - don't show it.

If no events to show - do not show the whole events section, show some (nicely done) stub - "No upcoming events"

If no banner - do not show banner.

@shcheklein shcheklein added A: website Area: website p1-important Active priorities to deal within next sprints type: feature-request DEPRECATED New feature or request labels May 10, 2020
@shcheklein shcheklein added p0-critical Affects users in a bad way at the moment and removed p1-important Active priorities to deal within next sprints labels May 10, 2020
@rogermparent rogermparent self-assigned this May 11, 2020
@elleobrien
Copy link
Contributor

elleobrien commented May 11, 2020

I've just made a PR to add a new banner about the mailing page (#1282). Maybe when an event expires, default to this banner instead of totally removing banner?

@rogermparent
Copy link
Contributor

rogermparent commented May 11, 2020

I've just made a PR to add a new banner about the mailing page (#1282). Maybe when an event expires, default to this banner instead of totally removing banner?

Sure! I was actually thinking about adding the functionality for having multiple Hero definitions queued up in an array and having the application use the first that isn't expired. This way, we can plan ahead and have these kinds of timed changes apply without worrying about a git merge. We can then have a "default" as the last item that never expires (and I'll add in functionality to the helpers so we can set something that never expires)

We can also log items that are expired so that we're reminded to remove stale ones and old data doesn't build up in the repo.

@shcheklein
Copy link
Member Author

@rogermparent @andronovhopf this sounds perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p0-critical Affects users in a bad way at the moment type: feature-request DEPRECATED New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants