Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support external links on the sidebar (quick fix) #1272

Closed
rogermparent opened this issue May 8, 2020 · 4 comments · Fixed by #1273
Closed

support external links on the sidebar (quick fix) #1272

rogermparent opened this issue May 8, 2020 · 4 comments · Fixed by #1273
Assignees
Labels
A: website Area: website p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc

Comments

@rogermparent
Copy link
Contributor

This issue is specifically to allow for external links on the current sidebar setup.
There are plans to renovate the sidebar code entirely, but it's worth fixing this issue in the current set-up because making a real sidebar overhaul may take a little while.

@rogermparent rogermparent self-assigned this May 8, 2020
@rogermparent rogermparent added p1-important Active priorities to deal within next sprints A: website Area: website labels May 8, 2020
@shcheklein shcheklein changed the title Support external links on the sidebar (quick fix) support external links on the sidebar (quick fix) May 8, 2020
@shcheklein shcheklein added website: eng-doc DEPRECATED JS engine for /doc type: enhancement Something is not clear, small updates, improvement suggestions labels May 8, 2020
@shcheklein
Copy link
Member

Related #897 #515

@jorgeorpinel
Copy link
Contributor

This looks like a duplicate of #897 essentially, bc/ hat's our only use case rn I think.

@jorgeorpinel
Copy link
Contributor

OK never mind I see a PR was also created so that's fine. @rogermparent keep in mind that if you're sending the PR right away you could sometimes skip creating the issue too 🙂

@shcheklein
Copy link
Member

@jorgeorpinel for the record, I asked Roger to create the ticket for visibility and since all other tickets are more content focused rather than engine. So, I thought that it would be beneficial to have an engine one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants