Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: replace pretty-quick --bail with lint-staged --no-stash #1249

Closed
jorgeorpinel opened this issue May 5, 2020 · 1 comment
Closed

lint: replace pretty-quick --bail with lint-staged --no-stash #1249

jorgeorpinel opened this issue May 5, 2020 · 1 comment
Labels
A: website Area: website dependencies Pull requests that update a dependency file (automatic) good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 5, 2020

Per lint-staged/lint-staged#745 (comment) there's a new flag in lint-staged to replace the bailing behaviot of pretty-quick, so we can now probably keep only the former,

Basically, revert this: https://github.com/iterative/dvc.org/pull/1130/files
and add the --no-stash option
+ test to double check 🙂

See https://github.com/okonet/lint-staged#command-line-flags

@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions good first issue Good for newcomers dependencies Pull requests that update a dependency file (automatic) labels May 5, 2020
@shcheklein shcheklein added the A: website Area: website label May 6, 2020
@jorgeorpinel
Copy link
Contributor Author

I tried to implement this change in #1252

But as explained in lint-staged/lint-staged#745 (comment) it's not doing what I expected.

So, leaving as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website dependencies Pull requests that update a dependency file (automatic) good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

2 participants