Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] dev: Twitter embeds don't hot-reload #1243

Closed
jorgeorpinel opened this issue May 5, 2020 · 1 comment
Closed

[minor] dev: Twitter embeds don't hot-reload #1243

jorgeorpinel opened this issue May 5, 2020 · 1 comment
Labels
A: website Area: website dependencies Pull requests that update a dependency file (automatic) status: wontfix This will not be worked on (e.g. a known issue). type: enhancement Something is not clear, small updates, improvement suggestions website: eng-blog DEPRECATED JS engine for /blog

Comments

@jorgeorpinel
Copy link
Contributor

When running on development, working on a blog post that has a Twitter embed, changing anything turns all the embeds into text.E.g. from

image

to

image

This causes all the contents to shift since the embed height is different.

Just wondering if this is something very easy to fix perhaps. Probably not worth putting much effort into this, unless it somehow affects the blog on prod.

And I've seen the Twitter embeds not work on prod sometimes but I think it was due to a plugin in my browser. Can't reproduce now.
@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions dependencies Pull requests that update a dependency file (automatic) website: eng-blog DEPRECATED JS engine for /blog labels May 5, 2020
@shcheklein shcheklein added the A: website Area: website label May 6, 2020
@weekly-digest weekly-digest bot mentioned this issue May 10, 2020
Closed
@jorgeorpinel
Copy link
Contributor Author

Too specific

@jorgeorpinel jorgeorpinel added the status: wontfix This will not be worked on (e.g. a known issue). label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: website Area: website dependencies Pull requests that update a dependency file (automatic) status: wontfix This will not be worked on (e.g. a known issue). type: enhancement Something is not clear, small updates, improvement suggestions website: eng-blog DEPRECATED JS engine for /blog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorgeorpinel @shcheklein