Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links in image captions can't contain underscore #1239

Closed
jorgeorpinel opened this issue May 5, 2020 · 6 comments
Closed

links in image captions can't contain underscore #1239

jorgeorpinel opened this issue May 5, 2020 · 6 comments
Labels
A: website Area: website p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. status: stale You've been groomed! 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog website: eng-doc DEPRECATED JS engine for /doc

Comments

@jorgeorpinel
Copy link
Contributor

E.g. Try linking to https://static.fossee.in/scipy2019/SciPyTalks/SciPyIndia2019_S011_Storing_a_few_versions_of_a_5GB_file_in_a_data_science_project_20191130.mp4 from an image caption. You get:

image

because the caption is surrounded by underscores _, probaly.

@jorgeorpinel jorgeorpinel added 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc website: eng-blog DEPRECATED JS engine for /blog labels May 5, 2020
@shcheklein
Copy link
Member

does %-encoding solve the problem in this case? it can be a good solution then.

@shcheklein shcheklein changed the title Links in image captions can't contain underscore links in image captions can't contain underscore May 5, 2020
@jorgeorpinel

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel
Copy link
Contributor Author

Yes, that works! But you have to manually replace with %5F since URL encoders online at least won't encode _. In this case I just used https://static.fossee.in/scipy2019/SciPyTalks/SciPyIndia2019%5FS011%5FStoring%5Fa%5Ffew%5Fversions%5Fof%5Fa%5F5GB%5Ffile%5Fin%5Fa%5Fdata%5Fscience%5Fproject%5F20191130.mp4.

@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions and removed 🐛 type: bug Something isn't working. labels May 5, 2020
@shcheklein
Copy link
Member

it's probably still a bug I would say, it's just we have a reasonable workaround here

@jorgeorpinel jorgeorpinel added 🐛 type: bug Something isn't working. and removed type: enhancement Something is not clear, small updates, improvement suggestions labels May 5, 2020
@shcheklein shcheklein added the A: website Area: website label May 7, 2020
@jorgeorpinel jorgeorpinel removed the A: website Area: website label May 9, 2021
@shcheklein shcheklein added p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. A: website Area: website labels Jul 26, 2021
@jorgeorpinel jorgeorpinel added the status: stale You've been groomed! label May 18, 2022
@jorgeorpinel
Copy link
Contributor Author

This hasn't been a problem again so closing (esp. since there's a workaround).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. status: stale You've been groomed! 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

No branches or pull requests

2 participants