Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: support lists properly in the descriptionLong frontmatter #1224

Closed
shcheklein opened this issue May 3, 2020 · 8 comments · Fixed by #2916
Closed

blog: support lists properly in the descriptionLong frontmatter #1224

shcheklein opened this issue May 3, 2020 · 8 comments · Fixed by #2916
Assignees
Labels
A: website Area: website C: blog TEMPORARY Content of /blog p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog

Comments

@shcheklein
Copy link
Member

shcheklein commented May 3, 2020

Right now we have to do something like:

https://github.com/iterative/dvc.org/pull/1213/files

to avoid bullet lists, since they look ugly.

@shcheklein shcheklein added 🐛 type: bug Something isn't working. A: website Area: website p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. website: eng-blog DEPRECATED JS engine for /blog labels May 3, 2020
@jorgeorpinel
Copy link
Contributor

So support Markdown in that field?

@shcheklein
Copy link
Member Author

we already support it. Just adjust CSS probably.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 3, 2020

Seems to work for me:
image

image

@shcheklein
Copy link
Member Author

I was not saying they were not working :) They just look ugly and not right.

@jorgeorpinel
Copy link
Contributor

OK so maybe just put the rendered descriptionLong in some CSS class so it the regular blog content formatting (perhaps just with slightly smaller font)? Or specifically we only want bullet lists? Thanks

@shcheklein
Copy link
Member Author

@jorgeorpinel not sure I understood you questions to be honest :). This ticket means adjusting CSS that we apply to this section. First step (and probably enough for this ticket) - lists (e.g. to align bullets with paragraphs, check the spacing, etc).

@julieg18
Copy link
Contributor

julieg18 commented Oct 7, 2021

@shcheklein, do we want the descriptionLong lists to look like this?

image

@shcheklein
Copy link
Member Author

@julieg18 yep, right. I think that was the main intention here. I would check how we render lists in docs (margins, etc) though.

@julieg18 julieg18 self-assigned this Oct 11, 2021
@iesahin iesahin added the C: blog TEMPORARY Content of /blog label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website C: blog TEMPORARY Content of /blog p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants