-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: make author name clickable, show description and posts by the author #1120
Comments
Does this mean a new template would have to be added in the src/templates folder additionally? |
@utkarshsingh99 as for the technical implementation, that would be the role of whoever takes this issue. Ivan or maybe @rogermparent can probalby give you some quick tips if needed. The design is probably not a big deal initially, once the page exists in a PR, we can worry about that part. |
Yes, I believe so! This template would then be called from
I'm not very good at design, so I can't help you here.
Yes, we have separate author nodes so we just need to use a GraphQL query in the The current Let me know if you need any help! Most of the schema logic handling stuff related to this was written by me, so I can help you find your way around. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
My idea is to re-use the Feed component used in the template
What do you think? |
@utkarshsingh99 I think you're mostly right, with a slight exception:
That said, something nearly identical to the blog home is a great starting point that we can work from, so I think going with your original plan is a good idea as long as we know it'll be more of a rough draft that we'll all refine together. With that in mind, don't worry too much about code duplication on your first version of the Author page since the code will probably be easier to change in a rougher state. Let's create the functionality we want now and optimize it before merge. Good luck! |
@rogermparent Just wanted to confirm if the graphql query I will be putting in should be fine.
The latter one seems to be more reasonable, but it will involve making another new component, and then re-using the Feed/Item component. Is this approach okay? |
@utkarshsingh99 Sounds reasonable to me! Even if I find an issue with it during review, getting the new page working with whatever schema works is the priority here- especially where it's likely to change soon afterward as we add new features to the Author pages. |
No description provided.
The text was updated successfully, but these errors were encountered: