From 34628c5713c6d12db042ab50dd69e02966731629 Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 08:29:05 -0400 Subject: [PATCH 1/8] Hide `--rm-watermark` flag on `cml comment create` --- bin/cml/comment/create.js | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/cml/comment/create.js b/bin/cml/comment/create.js index 1c3d110f0..409b9df9c 100644 --- a/bin/cml/comment/create.js +++ b/bin/cml/comment/create.js @@ -66,6 +66,7 @@ exports.options = kebabcaseKeys({ type: 'boolean', description: 'Avoid watermark; CML needs a watermark to be able to distinguish CML comments from others', + hidden: true, telemetryData: 'name' } }); From 7558530c4d5dab43834d2ca57854354f6ceba041 Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 08:31:35 -0400 Subject: [PATCH 2/8] Update create.test.js --- bin/cml/comment/create.test.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bin/cml/comment/create.test.js b/bin/cml/comment/create.test.js index 681ae8b05..4e36101e2 100644 --- a/bin/cml/comment/create.test.js +++ b/bin/cml/comment/create.test.js @@ -30,9 +30,7 @@ describe('Comment integration tests', () => { [string] [default: \\"https://asset.cml.dev\\"] --publish-native, --native Uses driver's native capabilities to upload assets instead of CML's storage; not available on GitHub - [boolean] - --rm-watermark Avoid watermark; CML needs a watermark to be able - to distinguish CML comments from others [boolean]" + [boolean]" `); }); }); From 918b02536b7e9c2b65f61c3f37de8707fcc11643 Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 16:56:12 -0400 Subject: [PATCH 3/8] Update connect.js --- bin/cml/tensorboard/connect.js | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/cml/tensorboard/connect.js b/bin/cml/tensorboard/connect.js index b0fac3c67..5f61f5469 100644 --- a/bin/cml/tensorboard/connect.js +++ b/bin/cml/tensorboard/connect.js @@ -145,6 +145,7 @@ exports.options = kebabcaseKeys({ rmWatermark: { type: 'boolean', description: 'Avoid CML watermark', + hidden: true, telemetryData: 'name' } }); From 06623b5830d6cac00d196969c45e1662f32708f5 Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 16:56:36 -0400 Subject: [PATCH 4/8] Update connect.test.js --- bin/cml/tensorboard/connect.test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bin/cml/tensorboard/connect.test.js b/bin/cml/tensorboard/connect.test.js index b6d23f9d1..d9d3b8867 100644 --- a/bin/cml/tensorboard/connect.test.js +++ b/bin/cml/tensorboard/connect.test.js @@ -29,8 +29,7 @@ describe('CML e2e', () => { 600 characters [string] --md Output as markdown [title || name](url) [boolean] -t, --title Markdown title, if not specified, param name will be used - [string] - --rm-watermark Avoid CML watermark [boolean]" + [string]" `); }); }); From 38e8eba347b9ca997cf7d43f6879280a912daacb Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 16:57:15 -0400 Subject: [PATCH 5/8] Update publish.js --- bin/cml/asset/publish.js | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/cml/asset/publish.js b/bin/cml/asset/publish.js index 1d09e12b8..fa07e165d 100644 --- a/bin/cml/asset/publish.js +++ b/bin/cml/asset/publish.js @@ -59,6 +59,7 @@ exports.options = kebabcaseKeys({ rmWatermark: { type: 'boolean', description: 'Avoid CML watermark.', + hidden: true, telemetryData: 'name' }, mimeType: { From 4811d937c2c42dcbf8009eb4d46fd70e9d41ca02 Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 16:57:40 -0400 Subject: [PATCH 6/8] Update publish.test.js --- bin/cml/asset/publish.test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/bin/cml/asset/publish.test.js b/bin/cml/asset/publish.test.js index 0d130912d..45bc71359 100644 --- a/bin/cml/asset/publish.test.js +++ b/bin/cml/asset/publish.test.js @@ -24,7 +24,6 @@ describe('CML cli test', () => { -t, --title Markdown title [title](url) or ![](url title) [string] --native Uses driver's native capabilities to upload assets instead of CML's storage; not available on GitHub [boolean] - --rm-watermark Avoid CML watermark. [boolean] --mime-type MIME type [string] [default: infer from the file contents]" `); }); From 6853f3cd472d4bdc99a65b46ab719542a056cee7 Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 20:04:54 -0400 Subject: [PATCH 7/8] Update publish.test.js --- bin/cml/asset/publish.test.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/bin/cml/asset/publish.test.js b/bin/cml/asset/publish.test.js index 45bc71359..f210666bf 100644 --- a/bin/cml/asset/publish.test.js +++ b/bin/cml/asset/publish.test.js @@ -20,11 +20,11 @@ describe('CML cli test', () => { --help Show help [boolean] Options: - --md Output in markdown format [title || name](url) [boolean] - -t, --title Markdown title [title](url) or ![](url title) [string] - --native Uses driver's native capabilities to upload assets instead - of CML's storage; not available on GitHub [boolean] - --mime-type MIME type [string] [default: infer from the file contents]" + --md Output in markdown format [title || name](url) [boolean] + -t, --title Markdown title [title](url) or ![](url title) [string] + --native Uses driver's native capabilities to upload assets instead of + CML's storage; not available on GitHub [boolean] + --mime-type MIME type [string] [default: infer from the file contents]" `); }); }); From 1d49da1e72ba5f7e8b5c7091a0d3183e81485800 Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 24 Oct 2022 20:06:17 -0400 Subject: [PATCH 8/8] Update connect.test.js --- bin/cml/tensorboard/connect.test.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/bin/cml/tensorboard/connect.test.js b/bin/cml/tensorboard/connect.test.js index d9d3b8867..66c332805 100644 --- a/bin/cml/tensorboard/connect.test.js +++ b/bin/cml/tensorboard/connect.test.js @@ -20,15 +20,15 @@ describe('CML e2e', () => { --help Show help [boolean] Options: - -c, --credentials TensorBoard credentials as JSON, usually found at - ~/.config/tensorboard/credentials/uploader-creds.json + -c, --credentials TensorBoard credentials as JSON, usually found at + ~/.config/tensorboard/credentials/uploader-creds.json [string] [required] - --logdir Directory containing the logs to process [string] - --name Tensorboard experiment title; max 100 characters [string] - --description Tensorboard experiment description in Markdown format; max - 600 characters [string] - --md Output as markdown [title || name](url) [boolean] - -t, --title Markdown title, if not specified, param name will be used + --logdir Directory containing the logs to process [string] + --name Tensorboard experiment title; max 100 characters [string] + --description Tensorboard experiment description in Markdown format; max + 600 characters [string] + --md Output as markdown [title || name](url) [boolean] + -t, --title Markdown title, if not specified, param name will be used [string]" `); });