Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require a token when not needed #515

Closed
casperdcl opened this issue May 14, 2021 · 4 comments
Closed

don't require a token when not needed #515

casperdcl opened this issue May 14, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@casperdcl
Copy link
Contributor

Basic commands such as cml-publish --version should succeed even without a token defined.

https://github.com/iterative/setup-cml/pull/31/checks?check_run_id=2583733405#step:9:8

@casperdcl casperdcl added the bug Something isn't working label May 14, 2021
@0x2b3bfa0
Copy link
Member

That issue was probably solved long ago, please keep in mind that it happens with 0.1.30 but not with 0.3.8 (latest)

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented May 14, 2021

For this use case, you may just check for a more recent specific version. Maybe 0.3.0?

@casperdcl
Copy link
Contributor Author

yep, works

@DavidGOrtega
Copy link
Contributor

That issue was probably solved long ago, please keep in mind that it happens with 0.1.30 but not with 0.3.8 (latest)

@0x2b3bfa0 I wish you memory. I did it and I do not remembered it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants