-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-host https://assets.cml.dev #291
Comments
@JamesMowatt CML has no limitations on image hosting. you just need to replace You can try to use your own S3 bucket (you will need to set permissions correctly) or some external image hosting services: https://stackoverflow.com/questions/2642570/whats-a-good-image-hosting-site-with-an-api-to-allow-me-upload-images-from-my-w If you use AWS we can even consider sharing assets.cml.dev source code with you. It can be even open-sourced at some point. What would be an ideal solution for you? |
Instead of uploading the image somewhere, you may consider to store the image encoded with base64 in the markdown file directly. |
@tmaier unfortunately, embedded (base64) images are not supported in GitHub md files: github/markup#270 (comment) This is why we decided to use a unified approach to publishing images. Does GitLab support base64 images? We can probably implement a special option or a command for GitLab. @DavidGOrtega do you know? |
@dmpetrov was this opened-sourced in the end? I'd like to be able to use our own (non-public) S3 buckets with |
Going to keep this issue until we release some instructions for a way to easier self-host the images, but we have added a URL option to cml publish so with the next release you can |
closing in favour of iterative/cml.dev#266 :) |
Is it possible to self-host https://assets.cml.dev
I am a little uncomfortable with the idea that this will upload files to a third-party server.
If it isn't something that can be self-hosted I am happy to raise a PR to support GS/S3.
The text was updated successfully, but these errors were encountered: