Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs: nesting #158

Closed
casperdcl opened this issue Nov 30, 2021 · 4 comments · Fixed by #167
Closed

tabs: nesting #158

casperdcl opened this issue Nov 30, 2021 · 4 comments · Fixed by #167
Assignees
Labels
A: website Area: website p1-important High priority

Comments

@casperdcl
Copy link
Contributor

Nested tabs (<tab title="Container"><tab title="sub"></tab></tab> would be nice. Not sure of how to show them in URLs though. Probably /?tab=Container-sub?

@casperdcl casperdcl added A: website Area: website p1-important High priority labels Nov 30, 2021
@julieg18
Copy link
Contributor

julieg18 commented Dec 1, 2021

Nested tabs ( would be nice. Not sure of how to show them in URLs though. Probably /?tab=Container-sub?

This is doable! As for naming, maybe ?tab=container&tab=sub-container? It could be lengthy if we had more than two layers, but I can't think of doc examples that would need more than two nested layers of tabs 🤔

@julieg18 julieg18 self-assigned this Dec 1, 2021
@casperdcl
Copy link
Contributor Author

casperdcl commented Dec 1, 2021

The problem with ?tab=Container&tab=sub is ambiguity between 2 top-level tabs versus nested tabs. Also ambiguity when clicking another tab (which of Containter and/or sub gets cleared?)

(Related example: from an #id perspective, concatenation with hyphens is fully supported, but 2nd level #ids aren't)

@julieg18
Copy link
Contributor

julieg18 commented Dec 6, 2021

Are we ok with how this looks styling wise?

image

I'm not sure how we could improve it 🤔

@casperdcl
Copy link
Contributor Author

iterative/gatsby-theme-iterative#138 would avoid the problem of alpha transparency addition taking us to multiple shades of grey.

I count at least 2 puns in that sentence.

Fine with sorting iterative/gatsby-theme-iterative#138 later though - it looks ok for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p1-important High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants