-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tabs: URL referencing #123
Comments
Do we want the tab query to be automatically added to the url when the user clicks on a tab? |
@julieg18 yes |
Do you think this could make urls look lengthy if we had multiple different sets of tabs on one page? For example: https://cml.dev/doc/cml-with-dvc?tab=google-cloud-storage&tab=windows. |
For now I think we should only support 1 |
Are we sure we want this behavior? Currently it seems like we don't have many similiar tab names minus github, gitlab, and bitbucket 🤔 |
yes, the GH/GL/BB tabs are important and frequent enough to make this desirable on https://cml.dev/doc. Potentially could clear |
Given:
Should be able to use:
/some/page?tab=Bar
(or/some/page#Bar
?) to auto-open the appropriate tab (p1-important
, Update markdown tabs #130)/some/page/?tab=Bar#sub-section
(or/some/page#Bar-sub-section
?) to auto-open the tab and scroll to containing section (p2-nice-to-have
)?tab=<arg>
when navigating to a different page (p2-nice-to-have
)Other tasks:
blocking Usage: add GitLab, Bitbucket sections #122The text was updated successfully, but these errors were encountered: